Skip to content

close open-ended pins for cuxfilter dependencies - #181

Merged
mike-wendt merged 2 commits into
rapidsai:branch-0.17from
AjayThorve:update_cuxfilter_dependencies
Dec 9, 2020
Merged

close open-ended pins for cuxfilter dependencies#181
mike-wendt merged 2 commits into
rapidsai:branch-0.17from
AjayThorve:update_cuxfilter_dependencies

Conversation

@AjayThorve

Copy link
Copy Markdown
Member

updated version pins for bokeh, panel, geopandas, pyproj, pydeck, datashader

@AjayThorve
AjayThorve requested a review from a team as a code owner December 3, 2020 22:51

@ajschmidt8 ajschmidt8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AjayThorve, thanks for knocking this out. Can you also add a version pin for pyppeteer in the line below?

https://github.com/rapidsai/integration/blob/branch-0.17/conda/recipes/rapids-build-env/meta.yaml#L112

@AjayThorve

Copy link
Copy Markdown
Member Author

@AjayThorve, thanks for knocking this out. Can you also add a version pin for pyppeteer in the line below?

https://github.com/rapidsai/integration/blob/branch-0.17/conda/recipes/rapids-build-env/meta.yaml#L112

@ajschmidt8, I added it

@mike-wendt

Copy link
Copy Markdown
Contributor

Asking @dillon-cullinan to help diagnose the test failures in the meta pkg for blazing. There may be a conflict and I want to see if it is due to these pins or something known

@mike-wendt mike-wendt added the 4 - Needs Tests Waiting for test results to make a decision label Dec 4, 2020
@mike-wendt

Copy link
Copy Markdown
Contributor

Looks like this is a Blazing issue, but lets wait until it is fixed to merge this to be sure

@mike-wendt mike-wendt added the DO NOT MERGE Hold off on merging; see PR for details label Dec 4, 2020
@dillon-cullinan

Copy link
Copy Markdown
Contributor

rerun tests

2 similar comments
@mike-wendt

Copy link
Copy Markdown
Contributor

rerun tests

@mike-wendt

Copy link
Copy Markdown
Contributor

rerun tests

@mike-wendt mike-wendt removed the DO NOT MERGE Hold off on merging; see PR for details label Dec 9, 2020
@mike-wendt
mike-wendt merged commit dae781c into rapidsai:branch-0.17 Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 - Needs Tests Waiting for test results to make a decision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants